From a21c55cbcc33a0e20e91d42c9d179fc2d5ff9f14 Mon Sep 17 00:00:00 2001 From: "Nathan.fooo" <86001920+appflowy@users.noreply.github.com> Date: Tue, 27 Aug 2024 14:57:00 +0800 Subject: [PATCH] chore: modify log level for some cases (#754) * chore: modify log level for some cases * chore: update logs --- libs/client-api/src/collab_sync/collab_stream.rs | 1 + .../appflowy-collaborate/src/collab/disk_cache.rs | 2 +- services/appflowy-collaborate/src/group/cmd.rs | 2 +- services/appflowy-collaborate/src/rt_server.rs | 11 +++++++++-- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/libs/client-api/src/collab_sync/collab_stream.rs b/libs/client-api/src/collab_sync/collab_stream.rs index fa4b65df..cc7e0828 100644 --- a/libs/client-api/src/collab_sync/collab_stream.rs +++ b/libs/client-api/src/collab_sync/collab_stream.rs @@ -124,6 +124,7 @@ where sv }; let msg = Message::Sync(SyncMessage::SyncStep1(sv)).encode_v1(); + trace!("Periodic sync step 1 for {}", object_id); sink.queue_msg(|msg_id| { ClientCollabMessage::new_update_sync(UpdateSync::new( origin.clone(), diff --git a/services/appflowy-collaborate/src/collab/disk_cache.rs b/services/appflowy-collaborate/src/collab/disk_cache.rs index 916d9da0..040d09d1 100644 --- a/services/appflowy-collaborate/src/collab/disk_cache.rs +++ b/services/appflowy-collaborate/src/collab/disk_cache.rs @@ -77,7 +77,7 @@ impl CollabDiskCache { query: QueryCollab, ) -> Result { event!( - Level::INFO, + Level::DEBUG, "try get {}:{} from disk", query.collab_type, query.object_id diff --git a/services/appflowy-collaborate/src/group/cmd.rs b/services/appflowy-collaborate/src/group/cmd.rs index 32d0bdf6..5c2752a7 100644 --- a/services/appflowy-collaborate/src/group/cmd.rs +++ b/services/appflowy-collaborate/src/group/cmd.rs @@ -195,7 +195,7 @@ where } } - #[instrument(level = "info", skip_all)] + #[instrument(level = "debug", skip_all)] async fn create_group( &self, user: &RealtimeUser, diff --git a/services/appflowy-collaborate/src/rt_server.rs b/services/appflowy-collaborate/src/rt_server.rs index 56a4ff17..da46a295 100644 --- a/services/appflowy-collaborate/src/rt_server.rs +++ b/services/appflowy-collaborate/src/rt_server.rs @@ -18,7 +18,7 @@ use database::collab::CollabStorage; use crate::client::client_msg_router::ClientMessageRouter; use crate::command::{spawn_collaboration_command, CLCommandReceiver}; use crate::connect_state::ConnectState; -use crate::error::RealtimeError; +use crate::error::{CreateGroupFailedReason, RealtimeError}; use crate::group::cmd::{GroupCommand, GroupCommandRunner, GroupCommandSender}; use crate::group::manager::GroupManager; use crate::indexer::IndexerProvider; @@ -228,7 +228,14 @@ where { Ok(_) => { if let Ok(Err(err)) = rx.await { - error!("Handle client collab message fail: {}", err); + if !matches!( + err, + RealtimeError::CreateGroupFailed( + CreateGroupFailedReason::CollabWorkspaceIdNotMatch { .. } + ) + ) { + error!("Handle client collab message fail: {}", err); + } } }, Err(err) => {