chk
/
AppFlowy-Cloud
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1101 from AppFlowy-IO/sort-quick-notes-by-update-time 

fix: sort quick notes by update time
This commit is contained in:
Khor Shu Heng 2024-12-26 11:42:42 +08:00 committed by GitHub
parent 1131818eb7 52f9ee071e
commit b8e9aa0291
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/database/src/quick_note.rs
View File

@ -55,7 +55,7 @@ pub async fn select_quick_notes_with_one_more_than_limit<
let json_path_query = format!("'$.**.insert ? (@ like_regex \".*{}.*\")'", search_term); let json_path_query = format!("'$.**.insert ? (@ like_regex \".*{}.*\")'", search_term);
query_builder.push(json_path_query); query_builder.push(json_path_query);
} }
query_builder.push(" ORDER BY created_at DESC"); query_builder.push(" ORDER BY updated_at DESC");
if let Some(limit) = limit { if let Some(limit) = limit {
query_builder.push(" LIMIT "); query_builder.push(" LIMIT ");
query_builder.push_bind(limit); query_builder.push_bind(limit);

16
tests/workspace/quick_note.rs
View File

@ -21,6 +21,8 @@ async fn quick_note_crud_test() {
// To ensure that the creation time is different // To ensure that the creation time is different
time::sleep(Duration::from_millis(1)).await; time::sleep(Duration::from_millis(1)).await;
} }
let quick_note_id_1 = quick_note_ids[0];
let quick_note_id_2 = quick_note_ids[1];
let quick_notes = client let quick_notes = client
.api_client .api_client
.list_quick_notes(workspace_uuid, None, None, None) .list_quick_notes(workspace_uuid, None, None, None)
@ -28,9 +30,9 @@ async fn quick_note_crud_test() {
.expect("list quick notes"); .expect("list quick notes");
assert_eq!(quick_notes.quick_notes.len(), 2); assert_eq!(quick_notes.quick_notes.len(), 2);
assert!(!quick_notes.has_more); assert!(!quick_notes.has_more);
assert_eq!(quick_notes.quick_notes[0].id, quick_note_id_2);
assert_eq!(quick_notes.quick_notes[1].id, quick_note_id_1);
let quick_note_id_1 = quick_note_ids[0];
let quick_note_id_2 = quick_note_ids[1];
let data_1 = json!([ let data_1 = json!([
{ {
"type": "paragraph", "type": "paragraph",
@ -79,12 +81,14 @@ async fn quick_note_crud_test() {
]); ]);
client client
.api_client .api_client
.update_quick_note(workspace_uuid, quick_note_id_1, data_1) .update_quick_note(workspace_uuid, quick_note_id_2, data_2)
.await .await
.expect("update quick note"); .expect("update quick note");
// To ensure that the update time is different
time::sleep(Duration::from_millis(1)).await;
client client
.api_client .api_client
.update_quick_note(workspace_uuid, quick_note_id_2, data_2) .update_quick_note(workspace_uuid, quick_note_id_1, data_1)
.await .await
.expect("update quick note"); .expect("update quick note");
let quick_notes = client let quick_notes = client
@ -108,7 +112,7 @@ async fn quick_note_crud_test() {
assert!(!quick_notes_with_offset_and_limit.has_more); assert!(!quick_notes_with_offset_and_limit.has_more);
assert_eq!( assert_eq!(
quick_notes_with_offset_and_limit.quick_notes[0].id, quick_notes_with_offset_and_limit.quick_notes[0].id,
quick_note_id_1 quick_note_id_2
); );
let quick_notes_with_offset_and_limit = client let quick_notes_with_offset_and_limit = client
.api_client .api_client
@ -119,7 +123,7 @@ async fn quick_note_crud_test() {
assert!(quick_notes_with_offset_and_limit.has_more); assert!(quick_notes_with_offset_and_limit.has_more);
assert_eq!( assert_eq!(
quick_notes_with_offset_and_limit.quick_notes[0].id, quick_notes_with_offset_and_limit.quick_notes[0].id,
quick_note_id_2 quick_note_id_1
); );
let filtered_quick_notes = client let filtered_quick_notes = client
.api_client .api_client