chk
/
AppFlowy-Cloud
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: publish nothing should result in error

This commit is contained in:
Zack Fu Zi Xiang 2024-07-30 09:55:29 +08:00
parent 4f8c6fef81
commit c185063847
No known key found for this signature in database
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/api/workspace.rs
View File

@ -1223,7 +1223,9 @@ async fn post_publish_collabs_handler(
} }
if accumulator.is_empty() { if accumulator.is_empty() {
return Ok(Json(AppResponse::Ok())); return Err(
AppError::InvalidRequest(String::from("did not receive any data to publish")).into(),
);
} }
biz::workspace::ops::publish_collabs(&state.pg_pool, &workspace_id, &user_uuid, &accumulator) biz::workspace::ops::publish_collabs(&state.pg_pool, &workspace_id, &user_uuid, &accumulator)
.await?; .await?;

10
tests/workspace/publish.rs
View File

@ -82,6 +82,16 @@ async fn test_publish_doc() {
let view_id_1 = uuid::Uuid::new_v4(); let view_id_1 = uuid::Uuid::new_v4();
let publish_name_2 = "publish-name-2"; let publish_name_2 = "publish-name-2";
let view_id_2 = uuid::Uuid::new_v4(); let view_id_2 = uuid::Uuid::new_v4();
{
// cannot publish nothing
let err = c
.publish_collabs::<MyCustomMetadata, &[u8]>(&workspace_id, vec![])
.await
.unwrap_err();
assert_eq!(err.code, ErrorCode::InvalidRequest);
}
c.publish_collabs::<MyCustomMetadata, &[u8]>( c.publish_collabs::<MyCustomMetadata, &[u8]>(
&workspace_id, &workspace_id,
vec![ vec![