From c4514ca5bf864d9ac477449e56b2f64261ec0f8d Mon Sep 17 00:00:00 2001 From: Bartosz Sypytkowski Date: Tue, 10 Dec 2024 10:12:33 +0100 Subject: [PATCH] chore: add explanation --- .../appflowy-collaborate/src/collab/cache/collab_cache.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/services/appflowy-collaborate/src/collab/cache/collab_cache.rs b/services/appflowy-collaborate/src/collab/cache/collab_cache.rs index af1d6230..b90f9b7c 100644 --- a/services/appflowy-collaborate/src/collab/cache/collab_cache.rs +++ b/services/appflowy-collaborate/src/collab/cache/collab_cache.rs @@ -269,6 +269,12 @@ impl CollabCache { self.disk_cache.batch_insert_collab(records).await?; + // We'll update cache in the background. The reason is that Redis + // doesn't have a good way to do batch insert, so we'll do it one + // by one which may take time if there are many records. + // + // Most of the code doesn't rely on the cache being the only source + // of truth and accepts possibility that its update may fail. let mem_cache = self.mem_cache.clone(); tokio::spawn(async move { let now = chrono::Utc::now().timestamp();