From f40f4b1583e9469c7cde6f9eac09c100a77d1e1f Mon Sep 17 00:00:00 2001 From: Bartosz Sypytkowski Date: Thu, 17 Oct 2024 12:58:20 +0200 Subject: [PATCH] chore: fix early return from redis collab update stream reader --- libs/collab-stream/src/client.rs | 2 +- services/appflowy-collaborate/src/group/group_init.rs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libs/collab-stream/src/client.rs b/libs/collab-stream/src/client.rs index 4117c7dc..cff4ace3 100644 --- a/libs/collab-stream/src/client.rs +++ b/libs/collab-stream/src/client.rs @@ -116,7 +116,7 @@ impl CollabRedisStream { Some(id) => Some(MessageId::try_from(id)?), } }; - while Some(since) < until { + while until.is_none() || since < until.unwrap() { let last_id = since.to_string(); let batch: CollabStreamUpdateBatch = conn .xread_options(&[&stream_key], &[&last_id], &read_options) diff --git a/services/appflowy-collaborate/src/group/group_init.rs b/services/appflowy-collaborate/src/group/group_init.rs index e04611c1..57df589f 100644 --- a/services/appflowy-collaborate/src/group/group_init.rs +++ b/services/appflowy-collaborate/src/group/group_init.rs @@ -523,7 +523,6 @@ impl CollabGroup { message_origin: &CollabOrigin, msg_id: MsgId, ) -> Result, RealtimeError> { - tracing::trace!("handling collab message: {}", msg_id); let mut decoder = DecoderV1::from(payload); let reader = MessageReader::new(&mut decoder); let mut ack_response = None;