From fa13422a059996b9893e07b9b14c6faee6e2a0cf Mon Sep 17 00:00:00 2001
From: "Nathan.fooo" <86001920+appflowy@users.noreply.github.com>
Date: Wed, 7 Feb 2024 13:00:29 +0800
Subject: [PATCH] chore: logs (#302)

* chore: logs

* chore: logs
---
 libs/realtime/src/collaborate/group.rs | 12 ++++--------
 src/api/workspace.rs                   |  1 -
 src/biz/collab/storage.rs              |  1 -
 3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/libs/realtime/src/collaborate/group.rs b/libs/realtime/src/collaborate/group.rs
index 156cb496..6b2f8f0f 100644
--- a/libs/realtime/src/collaborate/group.rs
+++ b/libs/realtime/src/collaborate/group.rs
@@ -47,7 +47,7 @@ where
       for (object_id, group) in groups.iter() {
         if group.is_inactive().await {
           inactive_group_ids.push(object_id.clone());
-          if inactive_group_ids.len() > 10 {
+          if inactive_group_ids.len() > 5 {
             break;
           }
         }
@@ -138,7 +138,7 @@ where
     }
   }
 
-  #[tracing::instrument(skip(self))]
+  #[tracing::instrument(level = "trace", skip(self))]
   async fn init_group(
     &self,
     uid: i64,
@@ -146,11 +146,7 @@ where
     object_id: &str,
     collab_type: CollabType,
   ) -> Arc<CollabGroup<U>> {
-    event!(
-      tracing::Level::INFO,
-      "Create new group for object_id:{}",
-      object_id
-    );
+    event!(tracing::Level::TRACE, "New group:{}", object_id);
     let collab = MutexCollab::new(CollabOrigin::Server, object_id, vec![]);
     let broadcast = CollabBroadcast::new(object_id, collab.clone(), 10);
     let collab = Arc::new(collab.clone());
@@ -170,7 +166,7 @@ where
       self.access_control.clone(),
     );
     collab.lock().add_plugin(Arc::new(plugin));
-    event!(tracing::Level::INFO, "Init group collab:{}", object_id);
+    event!(tracing::Level::TRACE, "Init group collab:{}", object_id);
     collab.lock_arc().initialize().await;
 
     self
diff --git a/src/api/workspace.rs b/src/api/workspace.rs
index d9109684..5ecc9043 100644
--- a/src/api/workspace.rs
+++ b/src/api/workspace.rs
@@ -465,7 +465,6 @@ async fn create_collab_list_handler(
 
   Ok(Json(AppResponse::Ok()))
 }
-#[instrument(level = "trace", skip(payload, state), err)]
 async fn get_collab_handler(
   user_uuid: UserUuid,
   payload: Json<QueryCollabParams>,
diff --git a/src/biz/collab/storage.rs b/src/biz/collab/storage.rs
index d7e5c667..f0732f96 100644
--- a/src/biz/collab/storage.rs
+++ b/src/biz/collab/storage.rs
@@ -111,7 +111,6 @@ where
       .context("acquire transaction to upsert collab")
       .map_err(AppError::from)?;
     let (params, workspace_id) = params.split();
-    // TODO(nathan): save list of collab within period of time to avoid too many pool connections
     self
       .upsert_collab_with_transaction(&workspace_id, uid, params, &mut transaction)
       .await?;